Skip to content

Conversation

@mpoimer
Copy link
Contributor

@mpoimer mpoimer commented Apr 8, 2024

No description provided.

@mpoimer mpoimer requested review from draskovits and mbuchetics April 8, 2024 13:07
#!/bin/bash
cd $(dirname $0)

./APIGeneration/make No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there an extra script for the generation? Am I missing something or could this be simplified to one script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it makes sense to have everything generation related in an own folder and this script is just for convenience from the root folder - we can also move everything in here if you want

README.md Outdated
brew install openapi-generator
```

Configuration can be edited in `APIGeneration/generator-config.json`, `APIGeneration/make` and `APIGeneration/.openapi-generator-ignore`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add instructions on how to execute the model generation

@fgeistert
Copy link
Contributor

I think we should also exclude the generated models from the swiftlint step - this can be done in the swiftlint config file

@mpoimer
Copy link
Contributor Author

mpoimer commented Apr 9, 2024

I think we should also exclude the generated models from the swiftlint step - this can be done in the swiftlint config file

@fgeistert
This is already done in the .swiftlint.yml, or am I missing something?

@mpoimer mpoimer requested a review from fgeistert April 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants