Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excalidraw: properly waiting for a socket to be authorized #3591

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

me-andre
Copy link
Contributor

@me-andre me-andre commented Feb 7, 2024

Describe the background of your pull request

What does your pull request do? Does it solve a bug (which one?), add a feature?

Additional context

Add any other context

Governance

  • Documentation is added
  • Test cases are added or updated

By submitting this pull request I confirm that:

@me-andre me-andre requested a review from hero101 February 7, 2024 13:50
Copy link
Collaborator

@hero101 hero101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems logical. It did not occur to me that you can nest listeners.
In theory this will be an issue when the same socket tries to connect to multiple rooms.

Pushed a commit to delete the variable from the config file.

@hero101 hero101 merged commit bdbaea6 into develop Feb 7, 2024
2 checks passed
@hero101 hero101 deleted the client-5502 branch February 7, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants