fix: getNestedTree with Model::shouldBeStrict() #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliziodev
added a commit
that referenced
this pull request
Jul 22, 2025
aliziodev
added a commit
that referenced
this pull request
Jul 22, 2025
* fix: getNestedTree with Model::shouldBeStrict() * ci(tests): update test workflow to include coverage and upgrade codecov * refactor(command): extract model class retrieval to method * feat(enums): add documentation and utility methods * feat(taxonomy): make taxonomy model configurable * test: add comprehensive test coverage for taxonomy features * style(tests): remove trailing whitespace in test files * fix(taxonomy): eager load children relation when getting descendants * test: disable lazy loading and add description field to products * test(command): add tests for handle method execution and signature * docs: add codecov badge and reorder existing badges * test(model): add description to fillable fields * test: add unit tests for DuplicateSlugException * test(taxonomy): add unit tests for taxonomy filtering functionality * test: add unit tests for TaxonomyManager * test(taxonomy): add additional unit tests for Taxonomy model * test: eager load nested children in taxonomy descendants test * test: add unit tests for TaxonomyProvider registration * test: remove unused ReflectionClass imports from test files * refactor(taxonomy): make wouldCreateCircularReference method public * test(taxonomy): add circular reference check in move operation test * test: add tests for rebuild nested set command and createOrUpdate method --------- Co-authored-by: HassanDomeDenea <hassan.domedenea@gmail.com>
|
Thanks for improving this – it’s merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running this line:
While having this in your configs/providers:
The following error would result (assuming you have some rows):
This was fixed and a test was added