Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lalibaba #2098

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Lalibaba #2098

wants to merge 22 commits into from

Conversation

juhuahaoteng
Copy link
Contributor

datasource_ess_alarms

@ghost ghost added the size/L label Jan 15, 2020
Type: schema.TypeString,
Optional: true,
},
"IsEnable": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注意命名规则 不要用大写和驼峰方式的命名

Type: schema.TypeString,
Computed: true,
ValidateFunc: validation.StringInSlice([]string{"system", "custom"}, false),
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

增加state过滤参数

Copy link
Contributor

@TalentNing TalentNing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

增加对应datasource的文档

@ghost ghost added size/XL and removed size/L labels Jan 15, 2020
Optional: true,
ValidateFunc: validation.StringInSlice([]string{"system", "custom"}, false),
},
"states": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个可以是state或者states,但是后面的代码都没有用到这个参数

@CLAassistant
Copy link

CLAassistant commented Aug 11, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants