Remove expire argument for url method and do not generate signed url for public/public-read bucket #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to solve python manage.py collectstatic run error! #2 TypeError: url() missing 1 required positional argument: 'expire' #9.
urlmethod is not compatible with django's defaultStorageclass since it should has only one required positional argument.Environment variable
OSS_EXPIRE_TIMEin seconds can be set for url expire time.If
OSS_EXPIRE_TIMEis not set, default value is60*60*24*30which is 30 days will be used.For public/public-read bucket, there is no need to use signed urls since it will generate unique url (Signature parameter in url will change each time) each time. This makes CDN or brower cache unavailable. Since OSS ususally serves as static/media file serving purpose, it is better to use constant urls for public/public-read buckets.