Skip to content

Conversation

@jxltom
Copy link

@jxltom jxltom commented Mar 27, 2018

  • Trying to solve python manage.py collectstatic run error! #2 TypeError: url() missing 1 required positional argument: 'expire' #9. url method is not compatible with django's default Storage class since it should has only one required positional argument.

    • Environment variable OSS_EXPIRE_TIME in seconds can be set for url expire time.

    • If OSS_EXPIRE_TIME is not set, default value is 60*60*24*30 which is 30 days will be used.

  • For public/public-read bucket, there is no need to use signed urls since it will generate unique url (Signature parameter in url will change each time) each time. This makes CDN or brower cache unavailable. Since OSS ususally serves as static/media file serving purpose, it is better to use constant urls for public/public-read buckets.

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2018

CLA assistant check
All committers have signed the CLA.

@jxltom jxltom changed the title Add default value for url expiring time Add default value for url expiring time and do not generate signed url for public/public-read bucket Mar 28, 2018
@jxltom jxltom changed the title Add default value for url expiring time and do not generate signed url for public/public-read bucket Remove expire argument for url method and do not generate signed url for public/public-read bucket Mar 28, 2018
@tiany
Copy link

tiany commented Sep 3, 2018

没人在维护吗?这么严重的Bug 5个月了还没合入的说 =。=

@huiguangjun
Copy link
Contributor

已经根据 修改内容 合入到 dev-1911 分支

@jxltom
Copy link
Author

jxltom commented Dec 16, 2019

Same with #11, why this PR is merged without my author information 😢

@tiany
Copy link

tiany commented Dec 16, 2019

Because they made the same changes instead of merge your PR... Quite interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants