Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine RAM role arn credentials provider #95

Merged
merged 1 commit into from
Aug 19, 2024
Merged

refine RAM role arn credentials provider #95

merged 1 commit into from
Aug 19, 2024

Conversation

JacksonTian
Copy link
Contributor

You need to complete
  • unit tests and/or feature tests
  • documentation is changed or added

@JacksonTian JacksonTian merged commit 09e2c68 into master Aug 19, 2024
8 checks passed
@JacksonTian JacksonTian deleted the ram branch August 19, 2024 10:04
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.29630% with 62 lines in your changes missing coverage. Please review.

Project coverage is 94.60%. Comparing base (cd6b32d) to head (8669e2e).
Report is 1 commits behind head on master.

Files Patch % Lines
credentials/internal/providers/http.go 18.51% 44 Missing ⚠️
credentials/internal/utils/utils.go 5.88% 16 Missing ⚠️
credentials/internal/providers/hook.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   98.16%   94.60%   -3.56%     
==========================================
  Files          23       26       +3     
  Lines        1416     1631     +215     
==========================================
+ Hits         1390     1543     +153     
- Misses         23       85      +62     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants