Skip to content

throw exception in asynchronous task #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

throw exception in asynchronous task #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions sdk/Common/Communication/netcore/ServiceClientNewImpl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,16 @@ protected override IAsyncResult BeginSendCore(ServiceRequest request, ExecutionC
var task = client.SendAsync(req, HttpCompletionOption.ResponseHeadersRead);
ServiceClientImpl.HttpAsyncResult result = new ServiceClientImpl.HttpAsyncResult(callback, state);
task.ContinueWith((resp) =>
{
ServiceResponse serviceResponse = new ResponseImpl(resp.Result);
result.Complete(serviceResponse);
{
// Exception can't be caught outside because it happens in Task.ContinueWith
// Exception won't be rethrow here
if (resp.IsFaulted)
result.Complete(resp.Exception);
else
{
ServiceResponse serviceResponse = new ResponseImpl(resp.Result);
result.Complete(serviceResponse);
}
});

return result;
Expand Down