Fix the'ParcelFileDescriptor not closed' bug

aliyun · Jul 23, 2021 · 591cfa2 · 591cfa2
1 parent cf8745b
commit 591cfa2
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/oss-android-sdk/src/main/java/com/alibaba/sdk/android/oss/network/OSSRequestTask.java b/oss-android-sdk/src/main/java/com/alibaba/sdk/android/oss/network/OSSRequestTask.java
@@ -1,5 +1,7 @@
 package com.alibaba.sdk.android.oss.network;
 
+import android.os.ParcelFileDescriptor;
+
 import com.alibaba.sdk.android.oss.ClientException;
 import com.alibaba.sdk.android.oss.ServiceException;
 import com.alibaba.sdk.android.oss.common.OSSHeaders;
@@ -129,7 +131,15 @@ public T call() throws Exception {
                         }
                     } else if (message.getUploadUri() != null) {
                         inputStream = context.getApplicationContext().getContentResolver().openInputStream(message.getUploadUri());
-                        length = context.getApplicationContext().getContentResolver().openFileDescriptor(message.getUploadUri(), "r").getStatSize();
+                        ParcelFileDescriptor parcelFileDescriptor = null;
+                        try {
+                            parcelFileDescriptor = context.getApplicationContext().getContentResolver().openFileDescriptor(message.getUploadUri(), "r");
+                            length = parcelFileDescriptor.getStatSize();
+                        } finally {
+                            if (parcelFileDescriptor != null) {
+                                parcelFileDescriptor.close();
+                            }
+                        }
                     } else if (message.getContent() != null) {
                         inputStream = message.getContent();
                         length = message.getContentLength();