forked from galaxydi/go-loghub
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add query for client #220
Merged
shabicheng
merged 5 commits into
aliyun:master
from
panawala:feature/add_query_for_client
Aug 15, 2023
Merged
add query for client #220
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -437,24 +437,37 @@ func (s *LogStore) GetCursor(shardID int, from string) (cursor string, err error | |
return cursor, nil | ||
} | ||
|
||
func (s *LogStore) GetLogsBytes(shardID int, cursor, endCursor string, | ||
logGroupMaxCount int) (out []byte, nextCursor string, err error) { | ||
plr := &PullLogRequest{ | ||
ShardID: shardID, | ||
Cursor: cursor, | ||
EndCursor: endCursor, | ||
LogGroupMaxCount: logGroupMaxCount, | ||
} | ||
return s.GetLogsBytesWithQuery(plr) | ||
} | ||
|
||
// GetLogsBytes gets logs binary data from shard specified by shardId according cursor and endCursor. | ||
// The logGroupMaxCount is the max number of logGroup could be returned. | ||
// The nextCursor is the next curosr can be used to read logs at next time. | ||
func (s *LogStore) GetLogsBytes(shardID int, cursor, endCursor string, | ||
logGroupMaxCount int) (out []byte, nextCursor string, err error) { | ||
func (s *LogStore) GetLogsBytesWithQuery(plr *PullLogRequest) (out []byte, nextCursor string, err error) { | ||
h := map[string]string{ | ||
"x-log-bodyrawsize": "0", | ||
"Accept": "application/x-protobuf", | ||
"Accept-Encoding": "lz4", | ||
} | ||
|
||
uri := "" | ||
if endCursor == "" { | ||
uri = fmt.Sprintf("/logstores/%v/shards/%v?type=logs&cursor=%v&count=%v", | ||
s.Name, shardID, cursor, logGroupMaxCount) | ||
} else { | ||
uri = fmt.Sprintf("/logstores/%v/shards/%v?type=logs&cursor=%v&end_cursor=%v&count=%v", | ||
s.Name, shardID, cursor, endCursor, logGroupMaxCount) | ||
uri := fmt.Sprintf("/logstores/%v/shards/%v?type=logs&cursor=%v&count=%v", | ||
s.Name, plr.ShardID, plr.Cursor, plr.LogGroupMaxCount) | ||
if plr.EndCursor != "" { | ||
uri += fmt.Sprintf("&end_cursor=%v", plr.EndCursor) | ||
} | ||
if plr.Query != "" { | ||
uri += fmt.Sprintf("&query=%v", plr.Query) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
} | ||
if plr.PullMode != "" { | ||
uri += fmt.Sprintf("&pullMode=%v", plr.PullMode) | ||
} | ||
|
||
r, err := request(s.project, "GET", uri, h, nil) | ||
|
@@ -536,8 +549,18 @@ func LogsBytesDecode(data []byte) (gl *LogGroupList, err error) { | |
// @note if you want to pull logs continuous, set endCursor = "" | ||
func (s *LogStore) PullLogs(shardID int, cursor, endCursor string, | ||
logGroupMaxCount int) (gl *LogGroupList, nextCursor string, err error) { | ||
plr := &PullLogRequest{ | ||
ShardID: shardID, | ||
Cursor: cursor, | ||
EndCursor: endCursor, | ||
LogGroupMaxCount: logGroupMaxCount, | ||
} | ||
return s.PullLogsWithQuery(plr) | ||
} | ||
|
||
func (s *LogStore) PullLogsWithQuery(plr *PullLogRequest) (gl *LogGroupList, nextCursor string, err error) { | ||
|
||
out, nextCursor, err := s.GetLogsBytes(shardID, cursor, endCursor, logGroupMaxCount) | ||
out, nextCursor, err := s.GetLogsBytesWithQuery(plr) | ||
if err != nil { | ||
return nil, "", err | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我想这个common的方法可以改个名字:PullLogsV2之类的?不要过于突出 Query(一些用户用不到这个功能,反而会多问)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已改为PullLogsV2,PullLogRequest放到了model.go里面