Use setuptools_scm to single-source an always-valid version number #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest pip versions fail to install a source checkout if its version is set to `LAST_TAG`, which we do for all untagged commits. Use setuptools_scm instead, so that we always have a valid, PEP440-compliant version number, even for commits in between tags.
Codecov Report
@@ Coverage Diff @@
## master #789 +/- ##
==========================================
- Coverage 84.92% 84.81% -0.11%
==========================================
Files 30 30
Lines 3064 3075 +11
==========================================
+ Hits 2602 2608 +6
- Misses 462 467 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TimoWilken
force-pushed
the
setuptools_scm
branch
from
0f3653e to
6d20c04
Compare
|
The new coverage misses are in the error checking in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest pip versions fail to install a source checkout if its version is set to
LAST_TAG, which we do for all untagged commits.Use setuptools_scm instead, so that we always have a valid, PEP440-compliant version number, even for commits in between tags.