STARLIGHT update (svn revision 286) #288

hcab14 · 2017-06-28T08:58:19Z

No description provided.

alibuild · 2017-06-28T08:58:39Z

4e4c79a: approval required: 1 of @rbertens (Redmer Alexander Bertens), @qgp (Jochen Klein)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

chiarazampolli · 2017-06-28T09:51:57Z

Hello Christoph,

Please, note that if you need to use this in production, you should also open a JIRA ticket (Production request) for this (once merged).

Chiara

rbertens · 2017-06-28T16:09:02Z

+test
@qgp , could you also take a look?
and @hcab14 , naive question maybe, but your commit message suggests this is a port from an svn repository. Is this really a new 'version' (in the sense that we could link the pull request to a README) or do you develop on your private svn and now merge?
thanks,
redmer

alibuild · 2017-06-28T16:09:27Z

4e4c79a: testing approved: will not be automatically merged; starting testing. If testing succeeds, merging will require further approval from 1 of @rbertens (Redmer Alexander Bertens), @qgp (Jochen Klein)

alibuild · 2017-06-28T16:14:42Z

4e4c79a: tests OK, approval required for merging: 1 of @rbertens (Redmer Alexander Bertens), @qgp (Jochen Klein)

Comment with +1 to merge. Please comment on the pull request: click here and comment at the bottom of the page.

alibuild · 2017-07-01T02:30:37Z

Error while checking build/AliRoot/release for 4e4c79a:

sw/BUILD/AliRoot-latest/log
71/93 Test  #2: load_library_ANALYSISaliceBase ...   Passed    0.30 sec
72/93 Test #71: load_library_MONITOR .............   Passed    0.50 sec
      Start  8: load_library_HERWIG
      Start 80: load_library_EvtGenExternal
73/93 Test #31: load_library_EMCALTriggerBase ....   Passed    0.35 sec
74/93 Test #82: load_library_THepMCParser ........   Passed    0.35 sec
75/93 Test #80: load_library_EvtGenExternal ......   Passed    0.17 sec
      Start 85: load_library_Tauola
      Start 13: load_library_pythia6
      Start 11: load_library_lhapdf
76/93 Test  #8: load_library_HERWIG ..............   Passed    0.25 sec
77/93 Test #11: load_library_lhapdf ..............   Passed    0.19 sec
78/93 Test #13: load_library_pythia6 .............   Passed    0.21 sec
      Start 20: load_library_pythia8210
      Start 81: load_library_EvtGen
      Start 84: load_library_Photos
79/93 Test #85: load_library_Tauola ..............   Passed    0.41 sec
80/93 Test #84: load_library_Photos ..............   Passed    0.28 sec
      Start  9: load_library_HIJING
      Start  6: load_library_dime
81/93 Test #20: load_library_pythia8210 ..........   Passed    0.29 sec
82/93 Test #81: load_library_EvtGen ..............   Passed    0.28 sec
83/93 Test  #6: load_library_dime ................   Passed    0.20 sec
      Start 21: load_library_pythia8210dev
      Start 12: load_library_lhapdf_5_9_1
      Start 17: load_library_pythia6_4_28
84/93 Test  #9: load_library_HIJING ..............   Passed    0.31 sec
85/93 Test #12: load_library_lhapdf_5_9_1 ........   Passed    0.17 sec
86/93 Test #17: load_library_pythia6_4_28 ........   Passed    0.24 sec
      Start 16: load_library_pythia6_4_25
      Start 83: load_library_HepMC
      Start 22: load_library_AMPT
87/93 Test #21: load_library_pythia8210dev .......   Passed    0.25 sec
88/93 Test #16: load_library_pythia6_4_25 ........   Passed    0.17 sec
89/93 Test #22: load_library_AMPT ................   Passed    0.17 sec
      Start 10: load_library_lhapdfbase
      Start 75: load_library_StarLight
      Start 15: load_library_pythia6_4_21
90/93 Test #83: load_library_HepMC ...............   Passed    0.18 sec
91/93 Test #15: load_library_pythia6_4_21 ........   Passed    0.15 sec
92/93 Test #10: load_library_lhapdfbase ..........   Passed    0.15 sec
93/93 Test #75: load_library_StarLight ...........   Passed    0.20 sec

100% tests passed, 0 tests failed out of 93

Total Test time (real) =  18.51 sec
+ rsync -a /mnt/mesos/sandbox/sandbox/sw/SOURCES/AliRoot/0/0/test/ /mnt/mesos/sandbox/sandbox/sw/slc7_x86-64/AliRoot/0-1/test
+ [[ RELWITHDEBINFO == COVERAGE ]]
+ mkdir -p /mnt/mesos/sandbox/sandbox/sw/slc7_x86-64/AliRoot/0-1/etc/modulefiles

Full log here.

alibuild · 2017-07-01T21:29:32Z

8f65719: approval required: 1 of @ecalvovi (Ernesto Calvo Villar), @mbroz84 (Michal Broz); 1 of @ekryshen (Evgeny Kryshen), @gconesab (Gustavo Conesa Balbastre), @wiechula (Jens Wiechula), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @mfloris (Michele Floris), @mvala (Martin Vala), @chiarazampolli (Chiara Zampolli), @pantonioli (Pietro Antonioli), @pchrista (Panos Christakoglou), @peressounko (Dmitri Peresunko), @zconesa (Zaida Conesa Del Valle), @deepathoms (Deepa Thomas), @lcunquei (Leticia Cunqueiro Mendez), @akalweit (Alexander Philipp Kalweit), @ddobrigk (David Dobrigkeit Chinellato), @shahor02 (Ruben Shahoyan); 1 of @loizides (Constantinos Loizides), @gconesab (Gustavo Conesa Balbastre), @guernane (Rachid Guernane), @mfasDa (Markus Fasel); 1 of @rbertens (Redmer Alexander Bertens), @qgp (Jochen Klein); 1 of @cholmcc (Christian Holm Christensen); 1 of @fprino (Francesco Prino), @mmasera (Massimo Masera), @iouribelikov (Jouri Belikov), @cterrevo (Cristina Terrevoli), @shahor02 (Ruben Shahoyan); 1 of @ginesmartinez (Gines Martinez-Garcia), @aphecetche (Laurent Aphecetche); 1 of @jgrosseo (Jan Fiete Grosse-Oetringhaus), @chiarazampolli (Chiara Zampolli), @qgp (Jochen Klein), @dberzano (Dario Berzano), @sawenzel (Sandro Christian Wenzel), @ktf (Giulio Eulisse), @shahor02 (Ruben Shahoyan); 1 of @miranov25 (Marian Ivanov); 1 of @mkrzewic (mkrzewic), @wiechula (Jens Wiechula), @miranov25 (Marian Ivanov), @haavardh (Haavard Helstrup), @jotwinow (Jacek Tomasz Otwinowski)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

hcab14 · 2017-07-01T21:34:46Z

Hi @rbertens,

it is an update from the STARLIGHT svn which adds more detailed printout on the cross section calculation but is not supposed to change the actual output. This is not my code/svn, (one of) the main author(s) of STARLIGHT is Joakim Nystrand.

Cheers
Christoph

hcab14 · 2017-07-01T21:41:53Z

Hi all,

I meant to add an explanation for 61193d4 in a pull request, but it got merged with this pull request:

this kind of problem has first been seen and corrected for in AD reconstruction
basically, the TTree (AD/Calib/Saturation) needs to know what type of object the TClonesArray branches contain
this is why the TClonesArray branches need to be properly initialized

Cheers
Christoph

ecalvovi · 2017-07-01T22:08:13Z

+1

alibuild · 2017-07-01T22:08:19Z

8f65719: approval required: 1 of @ekryshen (Evgeny Kryshen), @gconesab (Gustavo Conesa Balbastre), @wiechula (Jens Wiechula), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @mfloris (Michele Floris), @mvala (Martin Vala), @chiarazampolli (Chiara Zampolli), @pantonioli (Pietro Antonioli), @pchrista (Panos Christakoglou), @peressounko (Dmitri Peresunko), @zconesa (Zaida Conesa Del Valle), @deepathoms (Deepa Thomas), @lcunquei (Leticia Cunqueiro Mendez), @akalweit (Alexander Philipp Kalweit), @ddobrigk (David Dobrigkeit Chinellato), @shahor02 (Ruben Shahoyan); 1 of @loizides (Constantinos Loizides), @gconesab (Gustavo Conesa Balbastre), @guernane (Rachid Guernane), @mfasDa (Markus Fasel); 1 of @rbertens (Redmer Alexander Bertens), @qgp (Jochen Klein); 1 of @cholmcc (Christian Holm Christensen); 1 of @fprino (Francesco Prino), @mmasera (Massimo Masera), @iouribelikov (Jouri Belikov), @cterrevo (Cristina Terrevoli), @shahor02 (Ruben Shahoyan); 1 of @ginesmartinez (Gines Martinez-Garcia), @aphecetche (Laurent Aphecetche); 1 of @jgrosseo (Jan Fiete Grosse-Oetringhaus), @chiarazampolli (Chiara Zampolli), @qgp (Jochen Klein), @dberzano (Dario Berzano), @sawenzel (Sandro Christian Wenzel), @ktf (Giulio Eulisse), @shahor02 (Ruben Shahoyan); 1 of @miranov25 (Marian Ivanov); 1 of @mkrzewic (mkrzewic), @wiechula (Jens Wiechula), @miranov25 (Marian Ivanov), @haavardh (Haavard Helstrup), @jotwinow (Jacek Tomasz Otwinowski)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

gconesab · 2017-07-02T06:36:21Z

Hello, can this PR contain just what was changed and not what was already comitted? It is impossible to know if it was touched EMCal code or it is just a merge of a previous commit.

rbertens · 2017-07-02T08:29:30Z

HI @hcab14 ,
If you reopen the initial PR i'll +1 a.s.a.p.
my best,
redmer

hcab14 · 2017-07-02T08:46:50Z

Thank you @rbertens. I had performed a git pull --rebase origin master in between pushing my commits to my remote git repository and I guess this is why all the other commits were showing up in this PR.

As you have seem I have now opened a new PR #302

Cheers
Christoph

ecalvovi approved these changes Jul 1, 2017

View reviewed changes

hcab14 closed this Jul 2, 2017

hcab14 force-pushed the master branch from 8f65719 to 2c51844 Compare July 2, 2017 08:26

STARLIGHT update (svn revision 286) #288

STARLIGHT update (svn revision 286) #288

Uh oh!

Conversation

hcab14 commented Jun 28, 2017

Uh oh!

alibuild commented Jun 28, 2017

Uh oh!

chiarazampolli commented Jun 28, 2017

Uh oh!

rbertens commented Jun 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Jun 28, 2017

Uh oh!

alibuild commented Jun 28, 2017

Uh oh!

alibuild commented Jul 1, 2017

Uh oh!

alibuild commented Jul 1, 2017

Uh oh!

hcab14 commented Jul 1, 2017

Uh oh!

hcab14 commented Jul 1, 2017

Uh oh!

ecalvovi commented Jul 1, 2017

Uh oh!

alibuild commented Jul 1, 2017

Uh oh!

gconesab commented Jul 2, 2017

Uh oh!

rbertens commented Jul 2, 2017

Uh oh!

hcab14 commented Jul 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rbertens commented Jun 28, 2017 •

edited

Loading