Skip to content

Commit

Permalink
chore: fix dangerfile tap test detection
Browse files Browse the repository at this point in the history
  • Loading branch information
JackuB authored Oct 15, 2020
1 parent 4a4c045 commit 6b510d5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dangerfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ if (danger.github && danger.github.pr) {
return inTestFolder && !inLegacyAcceptanceTestsFolder && !testFilenameLooksLikeJest;
});

if (newTestFiles) {
if (newTestFiles.length) {
const joinedFileList = newTestFiles.map(f => '- `' + f + '`').join("\n");
const msg = `Looks like you added a new Tap test. Consider making it a Jest test instead. See files like \`test/*.spec.ts\` for examples. Files found:\n${joinedFileList}`;
warn(msg);
Expand Down

0 comments on commit 6b510d5

Please sign in to comment.