fix: highlight wrapper inside another wrapper not get updated when deleting #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleting When doing multi-color highlight, a highlight(A) created inside another highlight(B) is not get updated when deleting highlight(A). Though the highlight id is updated, but class list is not synced with highlight(B) which makes it to feel like it's not get deleted. This commit will make it to retain the wrapper classList which associated with the "extra id". related issue: alienzhou#58
|
This is the problem this PR trying to resolve, as you can see in the screenshot when doing highlight separately, deletion works perfectly. But when doing highlight inside another wrapper, deleting the inner highlight doesn't seem to work. The highlight id has been updated in factor, but just the class list did not get synced. |
|
@alienzhou Much appreciate it if you could have a look at this PR and #81 |
|
Sorry for the late reply. I'm a little busy these days. 😳 I'll check it out soon on this weekend. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a multi-color highlight, a highlight(A) created inside another
highlight(B) is not get updated when deleting highlight(A). Though the
highlight id is updated, the classLst is not synced with highlight(B)
which makes it feel like it's not get deleted.
This commit will make it to retain the wrapper classList which associated
with the "extra id".
related issue: #58