-
-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev remove cuda tex refs v2 #460
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR 420 is still unsolved but it has too many commits to rebase onto develop in acceptable time. This is PR compresses the work done so far. Problems with cards of CC 3.0 and below are still not understood. |
griwodz
force-pushed
the
dev_removeCudaTexRefs_v2
branch
from
August 3, 2018 07:05
3a4e3eb
to
ef8f724
Compare
[depthMap] differentiate access to Pitch mem on CUDA device [depthMap] differentiate access to 3D mem on CUDA device
griwodz
force-pushed
the
dev_removeCudaTexRefs_v2
branch
from
August 9, 2018 09:11
ec1d667
to
386dbba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CUDA texture references have been removed and replaced with texture objects. Instead of binding texture to memory before a kernel call and unbinding it after, the textures are now created at memory allocation time and destroyed at memory release.
The maintenance of textured CUDA memory is still global, but collected in a single object named "global_data". Untextured memory has not been touched.
Changes affect only depthMap/cuda. Prerequisite for understanding the side effects of slow kernels like refine_compUpdateYKNCCSimMapPatch_kernel.
Features list
Implementation remarks
The changes remove global CUDA texture references, which are a limited resource and require on-demand binding to and unbinding from CUDA memory. An unlimited number of CUDA texture objects can be allocated. Using texture objects has some advantages:
CUDA memory is frequently allocated like local variables and deallocated at function exit. For memory with textures, this wasteful behavior is now avoided. Memory is now drawn from a pool in global_data, and pushed back when is not needed any more. For low end GPUs, a compile flag or explicit release may be desirable to keep the old semantics.
A lot of dead code was removed in the process.