Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/3: get ssl handler in callback of connection establishment #1796

Merged
merged 2 commits into from
Jun 26, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
HTTP/3: only generate random cid without qch currently
  • Loading branch information
lianglli committed Jun 26, 2023
commit acabd8b1ae0f23aec718181582cf86f2964635d9
14 changes: 0 additions & 14 deletions modules/ngx_http_xquic_module/ngx_xquic.c
Original file line number Diff line number Diff line change
Expand Up @@ -616,20 +616,6 @@ ngx_xquic_generate_route_cid(unsigned char *buf, size_t len, const uint8_t *curr
/* fill with random data */
ngx_xquic_random_buf(buf, qmcf->cid_len);

/* keep server id */
if (current_cid_buf) {

if (XQC_UNLIKELY(current_cid_buflen < qmcf->cid_server_id_offset + qmcf->cid_server_id_length)) {
/* just return 0 to force xquic generate random cid */
ngx_log_error(NGX_LOG_WARN, ngx_cycle->log, 0, "|xquic|not enough buffer for server id space %d (required at least %d)",
current_cid_buflen, qmcf->cid_server_id_offset + qmcf->cid_server_id_length);
return 0;
}

/* copy server id */
ngx_memcpy(buf + qmcf->cid_server_id_offset, current_cid_buf + qmcf->cid_server_id_offset, qmcf->cid_server_id_length);
}

/* calculate salt */
salt = ngx_murmur_hash2(buf, qmcf->cid_worker_id_salt_range);

Expand Down