enable more test cases for ci.yml #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. fix error: Ssl_ctx_use_certificate key too small 2. make it case insensitive for checking "Verification: OK"
|
aslo cc @u5surf for ci.yml modified |
chobits
commented
Nov 11, 2022
| --with-ipv6 \ | ||
| --with-http_ssl_module \ | ||
| --with-http_v2_module \ | ||
| --with-http_addition_module \ |
There was a problem hiding this comment.
new compiled addtion module
chobits
commented
Nov 11, 2022
| --with-stream_realip_module \ | ||
| --with-stream_geoip_module \ | ||
| --with-stream_ssl_preread_module \ | ||
| --with-stream_sni \ |
There was a problem hiding this comment.
new compiled stream and stream_* module
chobits
commented
Nov 11, 2022
| @@ -875,7 +875,6 @@ ngx_stream_ssl_merge_conf(ngx_conf_t *cf, void *parent, void *child) | |||
|
|
|||
| #if (NGX_STREAM_SNI) | |||
| ngx_conf_merge_value(conf->sni_force, prev->sni_force, 0); | |||
| if (!conf->listen) | |||
There was a problem hiding this comment.
this line trigger potential segfault in ngx_ssl_error because it make conf->ssl.log NULL.
This line is duplicated with following line 882
if (!conf->listen) {
return NGX_CONF_OK;
}
chobits
commented
Nov 11, 2022
| @@ -45,7 +45,7 @@ EOF | |||
|
|
|||
| $t->write_file('openssl.conf', <<EOF); | |||
| [ req ] | |||
| default_bits = 1024 | |||
| default_bits = 2048 | |||
There was a problem hiding this comment.
ssl certificate key too small error
chobits
commented
Nov 11, 2022
| @@ -63,7 +63,8 @@ foreach my $name ('localhost') { | |||
|
|
|||
|
|
|||
| $t->run(); | |||
| my $ret1 = `openssl s_client -connect 127.0.0.1:8980 -dtls1 | grep "ok"`; | |||
| my $ret1 = `openssl s_client -connect 127.0.0.1:8980 -dtls1 | grep -i "ok"`; | |||
There was a problem hiding this comment.
ignore case of string checking
wa5i
approved these changes
Nov 11, 2022
wangfakang
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pr, all test cases in tests/nginx-tests/tengine-tests will be checked.