Skip to content

Conversation

harry-xm
Copy link
Contributor

Fix #1661

@chobits
Copy link
Member

chobits commented Oct 26, 2022

After patching wget https://github.com/alibaba/tengine/pull/1664.patch, cases passed

tests/nginx-tests/tengine-tests/dyups.t .. ok
All tests successful.
Files=1, Tests=78, 10 wallclock secs ( 0.04 usr  0.00 sys +  0.19 cusr  0.27 csys =  0.50 CPU)
Result: PASS

@chobits chobits merged commit f05854a into alibaba:master Oct 26, 2022
@chobits
Copy link
Member

chobits commented Oct 26, 2022

Although the code logic has bug, it will not cause real damage to nginx.
Because ngx_shmtx_unlock() will not unlock other worker's lock, it check the pid number with mutex, if the pid number(mutex lock) is not pid of current worker, it does nothing.

@chobits chobits added this to the 2.3.5 milestone Oct 26, 2022
@harry-xm harry-xm deleted the dyups-trylock branch October 26, 2022 13:21
@chobits chobits modified the milestones: 2.3.5, 2.4.0 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dyups module: inconsistent unlocking after trylock failure
2 participants