fix: NacosDataParserHandler yaml配置解析默认编码错误 - #4032
Open
ControlByDestiny wants to merge 1 commit into
Open
Conversation
|
|
Author
|
oss-sentinel-ai
approved these changes
Jul 21, 2026
oss-sentinel-ai
left a comment
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Summary
Correct fix for a real encoding issue on Chinese Windows systems (GBK default). YAML parsing requires Unicode, and the original code used configValue.getBytes() which defaults to the platform encoding. Adding a special case for YamlPropertySourceLoader to use StandardCharsets.UTF_8 resolves the startup failure.
Findings
- [Info] Import order:
java.nio.charset.StandardCharsetsis placed beforejava.io.IOException. Java convention is alphabetical withinjava.*imports. Minor style nit.
LGTM.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
中文的操作系统默认编码是GBK，Yaml解析只支持Unicode编码，默认编码不一致导致使用了配置中心的服务无法正常启动
Does this pull request fix one issue?
NONE
Describe how you did it
针对yaml配置获取bytes时指定UTF-8编码
Describe how to verify it
配置中心新增yaml配置，本地获取配置内容，要求本地默认编码非Unicode，且启动时未通过
-Dfile.encoding指定VM默认编码Special notes for reviews
NONE