Refactor CI workflow #500
Refactor CI workflow #500
Conversation
…nt-action Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
added
kind/enhancement
Codecov ReportBase: 53.17% // Head: 53.17% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #500 +/- ##
=======================================
Coverage 53.17% 53.17%
=======================================
Files 91 91
Lines 5896 5896
=======================================
Hits 3135 3135
Misses 2414 2414
Partials 347 347 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
details can refers to https://staticcheck.io/docs/checks/
| # vendor$, third_party$, testdata$, examples$, Godeps$, builtin$ | ||
| skip-dirs-use-default: true | ||
| skip-dirs: | ||
| - example |
| skip-dirs: | ||
| - example | ||
| skip-files: | ||
| - ".*\\.pb\\.go$" |
There was a problem hiding this comment.
recommends to add - _test.go
| @@ -0,0 +1,29 @@ | |||
| # Options for analysis running. | |||
| run: | |||
| # vendor$, third_party$, testdata$, examples$, Godeps$, builtin$ | |||
There was a problem hiding this comment.
recommends to add
# Include test files or not.
# Default: true
tests: false
|
following errors occurred in comments when check
|
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
binbin0325
left a comment
binbin0325
left a comment
There was a problem hiding this comment.
fix lint check ， delete core/hotspot/rule.go#104
|
@jnan806 @binbin0325 I'll merge this PR first (using rebase), then fix the lint error and improve linter config. |
4 participants
Signed-off-by: Eric Zhao sczyh16@gmail.com
Describe what this PR does / why we need it
Refactor CI workflow and split CI into two parts with golangci-lint-action.
Update go version to 1.16 in
go.mod.Does this pull request fix one issue?
Resloves #499
Describe how to verify it
The CI should pass.
Special notes for reviews
NONE