Skip to content

Bug: deprecated resource slot chain #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

louyuting
Copy link
Collaborator

Describe what this PR does / why we need it

Bug: deprecated resource slot chain in v 1.0.2

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@louyuting louyuting added kind/bug Something isn't working priority/urgent Most important, need to be worked on as soon as possible labels Jan 12, 2021
@louyuting louyuting force-pushed the 20201012-fix-v1-0-1-bug branch from ddb3103 to 77be833 Compare January 12, 2021 12:40
@codecov-io
Copy link

Codecov Report

Merging #379 (77be833) into v1.0.2-hotfix (f854c93) will decrease coverage by 0.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           v1.0.2-hotfix     #379      +/-   ##
=================================================
- Coverage          50.83%   50.40%   -0.44%     
=================================================
  Files                 69       68       -1     
  Lines               3842     3724     -118     
=================================================
- Hits                1953     1877      -76     
+ Misses              1621     1580      -41     
+ Partials             268      267       -1     
Impacted Files Coverage Δ
api/api.go 20.00% <0.00%> (+0.55%) ⬆️
api/slot_chain.go 92.85% <ø> (+16.38%) ⬆️
core/base/slot_chain.go 97.10% <ø> (-0.73%) ⬇️
core/circuitbreaker/rule_manager.go 72.62% <ø> (-0.46%) ⬇️
core/circuitbreaker/slot.go 94.11% <ø> (-5.89%) ⬇️
core/circuitbreaker/stat_slot.go 0.00% <ø> (-25.00%) ⬇️
core/flow/rule_manager.go 62.87% <ø> (-0.42%) ⬇️
core/flow/slot.go 41.37% <ø> (-5.29%) ⬇️
core/flow/standalone_stat_slot.go 57.14% <ø> (-17.86%) ⬇️
core/hotspot/concurrency_stat_slot.go 0.00% <ø> (-6.25%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f854c93...77be833. Read the comment docs.

@louyuting louyuting marked this pull request as ready for review January 12, 2021 12:45
@louyuting louyuting linked an issue Jan 12, 2021 that may be closed by this pull request
Copy link
Collaborator

@luckyxiaoqiang luckyxiaoqiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louyuting louyuting merged commit e48a6ef into alibaba:v1.0.2-hotfix Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working priority/urgent Most important, need to be worked on as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Dead Lock between Entry and LoadRules in v1.0.1
5 participants