Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration module for beego #61

Open
sczyh30 opened this issue Feb 24, 2020 · 4 comments · May be fixed by #93
Open

Add integration module for beego #61

sczyh30 opened this issue Feb 24, 2020 · 4 comments · May be fixed by #93
Assignees
@gorexlv
Labels
area/integrations Issue related to integrations with open-source components good first issue Good for newcomers kind/feature Category issues or PRs related to feature request

Comments

@sczyh30
Copy link
Member

sczyh30 commented Feb 24, 2020

Issue Description

Type: feature request

Describe what feature you want

Add integration module for beego. Discussions and contributions are welcomed!
@sczyh30 sczyh30 added good first issue Good for newcomers kind/feature Category issues or PRs related to feature request area/integrations Issue related to integrations with open-source components labels Feb 24, 2020
gorexlv added a commit to gorexlv/sentinel-golang that referenced this issue Mar 15, 2020
@gorexlv
fix alibaba#61; implement beego adapter
9c14396
@gorexlv
Copy link
Contributor

gorexlv commented Mar 15, 2020

I will deal with the issue if no one does :)

@louyuting
Copy link
Collaborator

Nice~I will assign this issue to U.

@sczyh30 sczyh30 linked a pull request Mar 16, 2020 that will close this issue
Implement beego adapter #93
Open
@sczyh30 sczyh30 added this to the 0.3.0 milestone Mar 19, 2020
@sczyh30 sczyh30 modified the milestones: 0.3.0, 0.4.0 Apr 7, 2020
gorexlv added a commit to gorexlv/sentinel-golang that referenced this issue Apr 14, 2020
@gorexlv
fix alibaba#61; implement beego adapter
f259e9e
@UnderTreeTech
Copy link

I don't think it's a good design. Why sentinel not expose callback, hooks or adapter interface definition. Thus any framework(like beego, gin, martini,etc.) can integrate sentinel.

@gorexlv
Copy link
Contributor

gorexlv commented May 6, 2020 •
edited
Loading

I don't think it's a good design. Why sentinel not expose callback, hooks or adapter interface definition. Thus any framework(like beego, gin, martini,etc.) can integrate sentinel.

@UnderTreeTech
Here is the definition doc: #61 (comment)

@sczyh30 sczyh30 modified the milestones: 0.4.0, 0.5.0 Jun 17, 2020
@sczyh30 sczyh30 modified the milestones: 0.5.0, 0.6.0 Jul 28, 2020
@louyuting louyuting removed this from the 0.6.0 milestone Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gorexlv gorexlv

Labels
area/integrations Issue related to integrations with open-source components good first issue Good for newcomers kind/feature Category issues or PRs related to feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement beego adapter gorexlv/sentinel-golang
4 participants
@gorexlv @UnderTreeTech @louyuting @sczyh30