Skip to content

Commit

Permalink
Configure artifact name and path separately (kubeflow#900)
Browse files Browse the repository at this point in the history
  • Loading branch information
Ark-kun authored and k8s-ci-robot committed Mar 6, 2019
1 parent 981222d commit 4cc70d4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions sdk/python/kfp/compiler/compiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,10 +236,10 @@ def _process_args(self, raw_args, argument_inputs):
def _op_to_template(self, op):
"""Generate template given an operator inherited from dsl.ContainerOp."""

def _build_conventional_artifact(name):
def _build_conventional_artifact(name, path):
return {
'name': name,
'path': '/' + name + '.json',
'path': path,
's3': {
# TODO: parameterize namespace for minio service
'endpoint': 'minio-service.kubeflow:9000',
Expand Down Expand Up @@ -301,8 +301,8 @@ def _build_conventional_artifact(name):
# for the artifact output when default artifact repository is configured,
# this part needs to be updated to use the default artifact repository.
output_artifacts = []
output_artifacts.append(_build_conventional_artifact('mlpipeline-ui-metadata'))
output_artifacts.append(_build_conventional_artifact('mlpipeline-metrics'))
output_artifacts.append(_build_conventional_artifact('mlpipeline-ui-metadata', '/mlpipeline-ui-metadata.json'))
output_artifacts.append(_build_conventional_artifact('mlpipeline-metrics', '/mlpipeline-metrics.json'))
template['outputs']['artifacts'] = output_artifacts

# Set resources.
Expand Down

0 comments on commit 4cc70d4

Please sign in to comment.