Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some rules and bug fix #328

Merged
merged 5 commits into from
Jun 13, 2018
Merged

add some rules and bug fix #328

merged 5 commits into from
Jun 13, 2018

Conversation

SeanCai
Copy link
Contributor

@SeanCai SeanCai commented Jun 12, 2018

add rules
[Recommended] The total number of lines for a method should not be more than 80
[Recommended] Avoid using the negation operator '!'
[Mandatory] When doing date formatting, "y" should be written in lowercase for "year" in a pattern statement

 and some bug fix

骏烈 added 3 commits June 12, 2018 14:45
 [Recommended] The total number of lines for a method should not be more than 80
 [Recommended] Avoid using the negation operator '!'
 [Mandatory] When doing date formatting, "y" should be written in lowercase for "year" in a pattern statement

 and some bug fix
@CLAassistant
Copy link

CLAassistant commented Jun 12, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


骏烈 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@LQZYC
Copy link
Contributor

LQZYC commented Jun 12, 2018

ok

@imu2008
Copy link
Contributor

imu2008 commented Jun 12, 2018

OK

@SeanCai SeanCai merged commit b0930cd into alibaba:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants