Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8309] Sync services and endpoints from k8s #9220

Merged

Conversation

EmanuelGi
Copy link

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

For issue #8309

Brief changelog

Sync services and endpoints from k8s.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2022

CLA assistant check
All committers have signed the CLA.

@@ -702,6 +719,11 @@
<level value="DEBUG"/>
<appender-ref ref="core-auth"/>
</logger>

<logger name="com.alibaba.nacos.k8s.sync.main" additivity="false">
<level value="DEBUG"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd be better defaults INFO .

@KomachiSion KomachiSion merged commit 3f3ea5e into alibaba:summer2022_issue#8309 Sep 29, 2022
@KomachiSion KomachiSion added Summer and removed Summer labels Apr 10, 2023
wukong121 pushed a commit to wukong121/nacos that referenced this pull request Aug 4, 2023
* [ISSUE#8309] Nacos supports synchronizing service metadata from k8s service discovery. (alibaba#7211)  * Synchronize k8s services.  * Synchronize k8s endpoints.

* ApiClient uses the default configuration instead

* Start registered Informers after registering handlers

* Compare oldServicePorts and newServicePorts to determine portChange

* Delete the logic of service renaming judgment

* Fix error in the process of registering instances

* Use independent log

* add k8s sync switch and start informer optimization

* start informer optimization
wukong121 pushed a commit to wukong121/nacos that referenced this pull request Aug 4, 2023
* [ISSUE#8309] Nacos supports synchronizing service metadata from k8s service discovery. (alibaba#7211)  * Synchronize k8s services.  * Synchronize k8s endpoints.

* ApiClient uses the default configuration instead

* Start registered Informers after registering handlers

* Compare oldServicePorts and newServicePorts to determine portChange

* Delete the logic of service renaming judgment

* Fix error in the process of registering instances

* Use independent log

* add k8s sync switch and start informer optimization

* start informer optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants