[ISSUE #9175] Support ldap filter config #9178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #9178 +/- ##
=============================================
+ Coverage 43.62% 43.71% +0.09%
- Complexity 4780 4787 +7
=============================================
Files 914 914
Lines 32709 32710 +1
Branches 3779 3779
=============================================
+ Hits 14269 14300 +31
+ Misses 17040 17007 -33
- Partials 1400 1403 +3
Continue to review full report at Codecov.
|
karsonto
changed the title
karsonto
changed the title
|
完善一下单元测试 |
onewe
reviewed
Sep 20, 2022
| @@ -171,6 +171,7 @@ nacos.core.auth.plugin.nacos.token.secret.key=SecretKey0123456789012345678901234 | |||
| #nacos.core.auth.ldap.userDn=cn=admin,${nacos.core.auth.ldap.basedc} | |||
| #nacos.core.auth.ldap.password=admin | |||
| #nacos.core.auth.ldap.userdn=cn={0},dc=example,dc=org | |||
| #nacos.core.auth.ldap.filter.prefix=uid | |||
There was a problem hiding this comment.
application.properties.example 这个文件也添加一下
onewe
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve issue #9175
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.