Add configurable for GrpcClient health check retry times #9056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #9056 +/- ##
=============================================
+ Coverage 43.66% 43.72% +0.06%
- Complexity 4776 4785 +9
=============================================
Files 912 913 +1
Lines 32599 32620 +21
Branches 3765 3769 +4
=============================================
+ Hits 14233 14263 +30
+ Misses 16963 16953 -10
- Partials 1403 1404 +1
Continue to review full report at Codecov.
|
KomachiSion
requested changes
Sep 1, 2022
| @@ -103,22 +111,17 @@ public GrpcClient(String name) { | |||
|
|
|||
| public GrpcClient(String name, Properties configProperties) { | |||
| super(name); | |||
| initGrpcClient(configProperties); | |||
| initGrpcClient(configProperties, NACOS_CLIENT_GRPC_THREADPOOL_KEEPALIVETIME, NACOS_CLIENT_GRPC_TIMEOUT, | |||
There was a problem hiding this comment.
Why list constants? If you want make them as an list or array, you can create an constant list in class or Constants
| this.timeOut = Long.parseLong(configProperties.getProperty(NACOS_CLIENT_GRPC_TIMEOUT)); | ||
| if (configProperties.contains(NACOS_CLIENT_GRPC_HEALTHCHECK_RETRY_TIMES)) { |
There was a problem hiding this comment.
Why not use same way with other parameters?
karsonto
force-pushed
the
develop-rpcclient-healthcheck-enhancement
branch
from
e6f0245
to
5ebc461
Compare
KomachiSion
approved these changes
Sep 2, 2022
| * | ||
| * @author karsonto | ||
| */ | ||
| public class GrpcConsts { |
There was a problem hiding this comment.
Consts --> Constants
I think full name is more readable.
KomachiSion
added
area/Client
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue #9013
添加GrpcClient健康检查可重试机制
e.g. nacos.remote.client.grpc.health.retry
nacos.remote.client.grpc.health.timeout
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.