-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #8622] 移除 environment 概念 #8991
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #8991 +/- ##
=============================================
+ Coverage 43.22% 43.61% +0.39%
- Complexity 4718 4757 +39
=============================================
Files 912 910 -2
Lines 32584 32639 +55
Branches 3761 3770 +9
=============================================
+ Hits 14085 14237 +152
+ Misses 17139 17000 -139
- Partials 1360 1402 +42
Continue to review full report at Codecov.
|
KomachiSion
requested changes
Aug 18, 2022
client/src/main/java/com/alibaba/nacos/client/env/JvmArgsPropertySource.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/alibaba/nacos/client/env/PropertiesPropertySource.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/alibaba/nacos/client/env/PropertiesPropertySource.java
Outdated
Show resolved
Hide resolved
KomachiSion
reviewed
Aug 22, 2022
client/src/main/java/com/alibaba/nacos/client/env/NProperties.java
Outdated
Show resolved
Hide resolved
KomachiSion
added
the
kind/enhancement
Category issues or prs related to enhancement.
label
Aug 22, 2022
- SYS更名为ENV - SHARED更改为PROTOTYPE
…add some comments
onewe
force-pushed
the
issues/8622-3
branch
from
September 21, 2022 06:43
94bfe30
to
bda5065
Compare
KomachiSion
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/Client
Related to Nacos Client SDK
kind/enhancement
Category issues or prs related to enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
移除 environment 概念使用 NProperties 代替, 详情见: https://www.yuque.com/docs/share/e9fcd9a3-f3fb-496d-9b8b-bf4b88db4df0?# 《Nacos-client 模块参数改造》
Related #8622.
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.