Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8622] 移除 environment 概念 #8991

Merged
merged 5 commits into from
Sep 22, 2022

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented Aug 18, 2022

移除 environment 概念使用 NProperties 代替, 详情见: https://www.yuque.com/docs/share/e9fcd9a3-f3fb-496d-9b8b-bf4b88db4df0?# 《Nacos-client 模块参数改造》

Related #8622.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #8991 (94bfe30) into develop (bf76143) will increase coverage by 0.39%.
The diff coverage is 85.61%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8991      +/-   ##
=============================================
+ Coverage      43.22%   43.61%   +0.39%     
- Complexity      4718     4757      +39     
=============================================
  Files            912      910       -2     
  Lines          32584    32639      +55     
  Branches        3761     3770       +9     
=============================================
+ Hits           14085    14237     +152     
+ Misses         17139    17000     -139     
- Partials        1360     1402      +42     
Impacted Files Coverage Δ
...a/com/alibaba/nacos/client/constant/Constants.java 16.66% <ø> (ø)
...ibaba/nacos/client/env/AbstractPropertySource.java 100.00% <ø> (ø)
...alibaba/nacos/client/env/SearchableProperties.java 77.52% <77.52%> (ø)
...nacos/client/env/DefaultSettingPropertySource.java 86.66% <83.33%> (+11.66%) ⬆️
...libaba/nacos/client/env/JvmArgsPropertySource.java 100.00% <100.00%> (ø)
...java/com/alibaba/nacos/client/env/NProperties.java 100.00% <100.00%> (ø)
...aba/nacos/client/env/PropertiesPropertySource.java 100.00% <100.00%> (ø)
.../java/com/alibaba/nacos/client/env/SourceType.java 100.00% <100.00%> (ø)
...baba/nacos/client/env/SystemEnvPropertySource.java 55.55% <100.00%> (+3.55%) ⬆️
...v2/upgrade/doublewrite/RefreshStorageDataTask.java 0.00% <0.00%> (-100.00%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf76143...94bfe30. Read the comment docs.

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Aug 22, 2022
@KomachiSion KomachiSion merged commit 6278e7e into alibaba:develop Sep 22, 2022
@KomachiSion KomachiSion added this to the 2.1.2 milestone Sep 22, 2022
@KomachiSion KomachiSion added the area/Client Related to Nacos Client SDK label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants