Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8701] ignore getServerList url #8727

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented Jul 11, 2022

Close #8701

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

- use http basic authentication
- disable csrf
@codecov-commenter
Copy link

Codecov Report

Merging #8727 (a1e7087) into develop (704210e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8727      +/-   ##
=============================================
- Coverage      43.18%   43.18%   -0.01%     
+ Complexity      4696     4693       -3     
=============================================
  Files            903      904       +1     
  Lines          32464    32468       +4     
  Branches        3752     3752              
=============================================
  Hits           14021    14021              
- Misses         17064    17089      +25     
+ Partials        1379     1358      -21     
Impacted Files Coverage Δ
...ess/config/AddressServerSecurityConfiguration.java 100.00% <100.00%> (ø)
...in/java/com/alibaba/nacos/sys/utils/InetUtils.java 31.03% <0.00%> (-24.14%) ⬇️
...m/alibaba/nacos/naming/misc/HttpClientManager.java 69.04% <0.00%> (-14.29%) ⬇️
...s/client/naming/core/ServiceInfoUpdateService.java 55.84% <0.00%> (-11.69%) ⬇️
...de/doublewrite/delay/DoubleWriteEventListener.java 53.70% <0.00%> (-9.26%) ⬇️
...onsistency/persistent/ClusterVersionJudgement.java 48.83% <0.00%> (-4.66%) ⬇️
...a/nacos/client/naming/backups/FailoverReactor.java 36.66% <0.00%> (-3.34%) ⬇️
...nacos/naming/healthcheck/v2/HealthCheckTaskV2.java 75.00% <0.00%> (-1.32%) ⬇️
...ava/com/alibaba/nacos/core/cluster/MemberUtil.java 72.72% <0.00%> (-1.02%) ⬇️
...s/naming/consistency/persistent/raft/RaftCore.java 9.68% <0.00%> (-0.20%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704210e...a1e7087. Read the comment docs.

Copy link
Contributor

@pixystone pixystone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KomachiSion KomachiSion merged commit 26f86e8 into alibaba:develop Jul 14, 2022
@onewe onewe deleted the issues/8701 branch July 14, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The address module can't use directly
4 participants