-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] add some unit tests and some integration tests for address module #8643
[Enhance] add some unit tests and some integration tests for address module #8643
Conversation
…module - add spring-boot-starter-test dependency - use constructor injection instead of field injection
5931851
to
8122a2e
Compare
address/src/test/java/com/alibaba/nacos/address/controller/ServerListControllerTest.java
Outdated
Show resolved
Hide resolved
address/src/test/java/com/alibaba/nacos/address/controller/ServerListControllerTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #8643 +/- ##
=============================================
+ Coverage 41.57% 41.93% +0.36%
- Complexity 4458 4512 +54
=============================================
Files 882 884 +2
Lines 32127 32252 +125
Branches 3721 3733 +12
=============================================
+ Hits 13357 13526 +169
+ Misses 17416 17370 -46
- Partials 1354 1356 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.