Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUES #8417] throw a HttpSessionRequiredException when sessions expired #8419

Merged
merged 5 commits into from
May 23, 2022

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented May 20, 2022

Close #8417

What is the purpose of the change

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion
Copy link
Collaborator

Please rebase develop branch, we have fixed the CI and IT problem.

@codecov-commenter
Copy link

Codecov Report

Merging #8419 (f86e444) into develop (58968f9) will decrease coverage by 0.03%.
The diff coverage is 42.85%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8419      +/-   ##
=============================================
- Coverage      41.12%   41.08%   -0.04%     
+ Complexity      4376     4375       -1     
=============================================
  Files            873      873              
  Lines          31814    31818       +4     
  Branches        3707     3707              
=============================================
- Hits           13084    13074      -10     
- Misses         17420    17430      +10     
- Partials        1310     1314       +4     
Impacted Files Coverage Δ
...os/plugin/auth/impl/controller/UserController.java 21.87% <42.85%> (+6.87%) ⬆️
...ibaba/nacos/core/cluster/lookup/LookupFactory.java 50.84% <0.00%> (-16.95%) ⬇️
...os/core/cluster/lookup/FileConfigMemberLookup.java 65.21% <0.00%> (-13.05%) ⬇️
...libaba/nacos/core/cluster/ServerMemberManager.java 54.58% <0.00%> (-1.84%) ⬇️
...a/nacos/core/remote/control/TpsMonitorManager.java 54.54% <0.00%> (-0.65%) ⬇️
...s/naming/consistency/persistent/raft/RaftCore.java 9.92% <0.00%> (+0.19%) ⬆️
...os/client/auth/ram/identify/CredentialService.java 82.69% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58968f9...f86e444. Read the comment docs.

@KomachiSion KomachiSion merged commit d6f2740 into alibaba:develop May 23, 2022
@onewe onewe deleted the issues/8417 branch May 23, 2022 07:20
@onewe onewe mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nacos权限认证失败,直接弹出到登陆界面
3 participants