Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize IoUtils and Add some unit test #8398

Merged
merged 3 commits into from
May 23, 2022

Conversation

karsonto
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@karsonto karsonto force-pushed the develop-optimize-IoUitlsAndTest branch 3 times, most recently from 9f58529 to b5df774 Compare May 18, 2022 09:01
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #8398 (5dc467d) into develop (58968f9) will increase coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8398      +/-   ##
=============================================
+ Coverage      41.12%   41.13%   +0.01%     
- Complexity      4376     4378       +2     
=============================================
  Files            873      873              
  Lines          31814    31809       -5     
  Branches        3707     3707              
=============================================
+ Hits           13084    13086       +2     
+ Misses         17420    17415       -5     
+ Partials        1310     1308       -2     
Impacted Files Coverage Δ
...n/java/com/alibaba/nacos/common/utils/IoUtils.java 9.83% <40.00%> (+0.38%) ⬆️
...a/nacos/core/remote/control/TpsMonitorManager.java 54.54% <0.00%> (-0.65%) ⬇️
...alibaba/nacos/core/remote/control/TpsRecorder.java 75.67% <0.00%> (+1.35%) ⬆️
...os/client/auth/ram/identify/CredentialService.java 82.69% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58968f9...5dc467d. Read the comment docs.

Oliverwqcwrw
Oliverwqcwrw previously approved these changes May 20, 2022
@KomachiSion
Copy link
Collaborator

Please rebase develop branch, we have fixed the CI and IT problem.

reformat codes

fix Too many unapproved license issue

fix Too many unapproved license issue

fix Too many unapproved license issue

fix Too many unapproved license issue

fix Too many unapproved license issue
@KomachiSion KomachiSion merged commit 89a0f89 into alibaba:develop May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants