Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some failing unit tests in nacos config module #8379

Merged
merged 2 commits into from
May 16, 2022

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented May 14, 2022

Close #8348

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #8379 (f424619) into develop (eb57028) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8379      +/-   ##
=============================================
- Coverage      41.24%   41.22%   -0.03%     
- Complexity      4370     4371       +1     
=============================================
  Files            873      873              
  Lines          31821    31821              
  Branches        3706     3706              
=============================================
- Hits           13125    13118       -7     
- Misses         17388    17394       +6     
- Partials        1308     1309       +1     
Impacted Files Coverage Δ
...os/client/auth/ram/identify/CredentialService.java 78.84% <0.00%> (-3.85%) ⬇️
...ent/manager/impl/EphemeralIpPortClientManager.java 66.00% <0.00%> (-2.00%) ⬇️
...m/alibaba/nacos/core/remote/ConnectionManager.java 44.37% <0.00%> (-1.48%) ⬇️
...alibaba/nacos/client/config/impl/ClientWorker.java 50.39% <0.00%> (-0.20%) ⬇️
.../naming/push/v1/NamingSubscriberServiceV1Impl.java 66.66% <0.00%> (ø)
...naming/core/v2/metadata/NamingMetadataManager.java 79.74% <0.00%> (+1.26%) ⬆️
...a/com/alibaba/nacos/naming/push/v1/PushClient.java 46.93% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb57028...f424619. Read the comment docs.

@onewe
Copy link
Collaborator Author

onewe commented May 16, 2022

image
image
image
image
image
image

@KomachiSion KomachiSion merged commit 6de92e4 into alibaba:develop May 16, 2022
@onewe onewe deleted the issues/8348 branch May 16, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix some failing unit tests in nacos config module
3 participants