[ISSUE #5096] Add unit tests to package com.alibaba.nacos.naming.healthcheck in nacos 2.0 #5170
Conversation
|
|
|
Please sign your CLA first |
naming/src/test/java/com/alibaba/nacos/naming/healthcheck/v2/HealthCheckTaskV2Test.java
Outdated
Show resolved
Hide resolved
| verify(switchDomain, times(3)).isHealthCheckEnabled(service.getGroupedServiceName()); | ||
| } | ||
|
|
||
| private List<Service> returnService() { |
There was a problem hiding this comment.
Can replace with Collections.singleList
There was a problem hiding this comment.
Can replace with Collections.singleList
fix
| private HealthCheckCommonV2 healthCheckCommonV2; | ||
|
|
||
| @Before | ||
| public void init() { |
There was a problem hiding this comment.
Before method name should be setUp
There was a problem hiding this comment.
Before method name should be setUp
fix
| } | ||
|
|
||
| @Test | ||
| public void reEvaluateCheckRT() { |
There was a problem hiding this comment.
test method should start with test
There was a problem hiding this comment.
test method should start with
test
fix
| private HealthCheckProcessorV2Delegate healthCheckProcessorV2Delegate; | ||
|
|
||
| @Before | ||
| public void initBean() { |
There was a problem hiding this comment.
Before method name should be setUp
There was a problem hiding this comment.
Before method name should be setUp
fix
...va/com/alibaba/nacos/naming/healthcheck/v2/processor/HealthCheckProcessorV2DelegateTest.java
Outdated
Show resolved
Hide resolved
| private HttpHealthCheckProcessor httpHealthCheckProcessor; | ||
|
|
||
| @Before | ||
| public void initBean() { |
There was a problem hiding this comment.
Before method name should be setUp
There was a problem hiding this comment.
Before method name should be setUp
fix
|
|
||
| Assert.assertNotNull(objects); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Same problem as last exception handle
There was a problem hiding this comment.
Same problem as last exception handle
fix
a part of fixing ISSUE #5096
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.