Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4681] Fix miss line break for query config. #4688

Conversation

shiyiyue1102
Copy link
Collaborator

@shiyiyue1102 shiyiyue1102 commented Jan 13, 2021

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fix #4681 .

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion changed the title query config line break miss bugfix . [ISSUE #4681] Fix miss line break for query config. Jan 13, 2021
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Jan 13, 2021
@KomachiSion KomachiSion added this to the 2.0.0 milestone Jan 13, 2021
@KomachiSion KomachiSion merged commit 79b39db into alibaba:feature_support_grpc_core Jan 13, 2021
@CherishCai
Copy link
Contributor

CherishCai commented Jan 14, 2021

这份文件应该是 配置保存时候写数据库,并各个 Server 都维护 local file 备份,那么这个换行的符号很难说下?如果是多个换行符,或者有 \r\n 等存在?
感觉直接读 file 字节 然后转字符串是最好的实现?
org.apache.commons.io.FileUtils.readFileToString(file);

@shiyiyue1102 @KomachiSion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants