[ISSUE-#4594,#4596] Fix IO close problem #4606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maijh97
changed the title
Closed
KomachiSion
requested changes
Dec 31, 2020
| @@ -249,21 +248,15 @@ public void setHealthStatus(String healthStatus) { | |||
| * @throws Exception Exception. | |||
| */ | |||
| private void execute(Connection conn, String sqlFile) throws Exception { | |||
| Statement stmt = null; | |||
| try { | |||
| try (Statement stmt = conn.createStatement()) { | |||
There was a problem hiding this comment.
Is this grammar supported after 1.7 JDK. I remember 1.X version client is 1.6JDK
There was a problem hiding this comment.
Support JDK 7. This syntax is only used on the server side.
KomachiSion
approved these changes
Dec 31, 2020
wjm0729
added a commit
to wjm0729/nacos
that referenced
this pull request
Dec 31, 2020
…op-import-v2 * 'develop' of https://github.com/alibaba/nacos: 优化 FileTypeEnum 取值逻辑, 避免使用异常当作逻辑分支 (alibaba#4607) for alibaba#4594,alibaba#4594 Fix IO close problem. (alibaba#4606) console-ui config排序优化 (alibaba#4599)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
fix: #4594 #4596
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.