Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4236] Add RequestContent and set attribute Overwrite to true to resolve the Apache Header Already Present problem #4237

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

Maijh97
Copy link
Collaborator

@Maijh97 Maijh97 commented Nov 16, 2020

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix: #4236

Brief changelog

Modify the RequestContent attribute overwrite to true to override the manually added content-length and transfer-Encoding.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@Maijh97 Maijh97 changed the title [ISSUE #4236] Manually adding Content-Length will cause apache http client exception [ISSUE #4236] Add RequestContent and set Overwrite to true to resolve the Apache Header Already Present problem Nov 16, 2020
@Maijh97 Maijh97 changed the title [ISSUE #4236] Add RequestContent and set Overwrite to true to resolve the Apache Header Already Present problem [ISSUE #4236] Add RequestContent and set attribute Overwrite to true to resolve the Apache Header Already Present problem Nov 16, 2020
Copy link
Collaborator

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KomachiSion KomachiSion added this to the 1.4.1 milestone Nov 16, 2020
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Nov 16, 2020
@KomachiSion KomachiSion merged commit 0a983c8 into alibaba:develop Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually adding Content-Length will cause apache http client exception
3 participants