Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2835] Fix an uncaught exception when accessing restricted namespace in authentication mode. #3541

Merged
merged 4 commits into from
Aug 10, 2020

Conversation

ljhrot
Copy link
Contributor

@ljhrot ljhrot commented Aug 6, 2020

#2835

What is the purpose of the change

Fix an uncaught exception when accessing restricted namespace in authentication mode.

Brief changelog

Fix an uncaught exception when accessing restricted namespace in authentication mode.

Verifying this change

  1. 修改配置 nacos.core.auth.enabled=true 开启鉴权。
  2. 使用 nacos/nacos 登陆,创建新的 namespace。
  3. 创建新的账号,只赋予上面创建的 namespace 管理权限,这个时候新的账号是没有 public 和其他 namespace 的管理权限的。
  4. 使用上面创建的账号登陆,访问没有权限的 namespace,提示 没有权限! 即为正常。

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion merged commit c45542c into alibaba:develop Aug 10, 2020
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Aug 10, 2020
@KomachiSion KomachiSion added this to the 1.4.0 milestone Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants