Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3103] Fix can't create properties config #3483

Merged
merged 3 commits into from
Jul 31, 2020
Merged

[ISSUE #3103] Fix can't create properties config #3483

merged 3 commits into from
Jul 31, 2020

Conversation

ljhrot
Copy link
Contributor

@ljhrot ljhrot commented Jul 30, 2020

#3103

alibaba-fusion\nextDialog 并不需要传递 language 支持国际化,本身 locale 变量已经处理好国际化了。https://github.com/alibaba-fusion/next/blob/97f4b53d23c2f7199150ec850d5e1b786585ab90/types/dialog/index.d.ts

Properties 格式的配置内容校验太简单了,我照着 JDK 的 java.util.Properties 来了个 javascript 版本的,因为
现成的 properties-readerjava-properties 都不能满足需求。

What is the purpose of the change

Fix can't create properties config

Brief changelog

  1. 删除 Dialoglanguage 参数
  2. 更新 Properties 格式校验

Verifying this change

新建配置选中 Properties,输入下面内容然后发布。

# You are reading the ".properties" entry.
! The exclamation mark can also mark text as comments.
# The key and element characters #, !, =, and : are written with
# a preceding backslash to ensure that they are properly loaded.
website = http\://en.wikipedia.org/
language = English
# The backslash below tells the application to continue reading
# the value onto the next line.
message = Welcome to \
          Wikipedia\!
# Add spaces to the key
key\ with\ spaces = This is the value that could be looked up with the key "key with spaces".
# Unicode
tab : \u0009

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@ljhrot
Copy link
Contributor Author

ljhrot commented Jul 31, 2020

@zongtanghu Please help with the review.

@KomachiSion KomachiSion merged commit 4310b3e into alibaba:develop Jul 31, 2020
@KomachiSion KomachiSion added area/Nacos console Related to Nacos consle kind/enhancement Category issues or prs related to enhancement. labels Jul 31, 2020
@KomachiSion KomachiSion added this to the 1.3.2 milestone Jul 31, 2020
@ljhrot ljhrot deleted the develop-issue#3103 branch July 31, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants