Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3428] Fix token valid go login bug #3449

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

senekis316
Copy link
Contributor

@senekis316 senekis316 commented Jul 26, 2020

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

For #3428, Fix token valid go login bug

Brief changelog

console/src/main/resources/static/console-fe/src/globalLib.js:531
console/src/main/resources/static/console-fe/src/utils/request.js:88

Verifying this change

test completion! token valid go login success!

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2020

CLA assistant check
All committers have signed the CLA.

@senekis316 senekis316 changed the title Fix #3428, Fix token valid go login bug [ISSUE #3428] Fix token valid go login bug Jul 26, 2020
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/Nacos console Related to Nacos consle labels Jul 27, 2020
@KomachiSion KomachiSion added this to the 1.3.2 milestone Jul 27, 2020
@KomachiSion KomachiSion merged commit d19b441 into alibaba:develop Jul 27, 2020
lancediarmuid pushed a commit to lancediarmuid/nacos that referenced this pull request Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants