[#3368]Cancel empty Long polling thread to improve performance. #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
KomachiSion
added
the
kind/enhancement
binbin0325
force-pushed
the
cancel_long_polling_thread
branch
from
2190e36
to
d3057d4
Compare
update clientWorker
zongtanghu
reviewed
Jul 27, 2020
client/src/main/java/com/alibaba/nacos/client/config/impl/ClientWorker.java
Outdated
Show resolved
Hide resolved
zongtanghu
reviewed
Jul 27, 2020
client/src/main/java/com/alibaba/nacos/client/config/impl/ClientWorker.java
Outdated
Show resolved
Hide resolved
|
And please add test cases codes for this pr, @sanxun0325 |
zongtanghu
changed the title
…cos into cancel_long_polling_thread # Conflicts: # client/src/main/java/com/alibaba/nacos/client/config/impl/ClientWorker.java
|
@zongtanghu Please help with the review. |
zongtanghu
reviewed
Jul 29, 2020
client/src/test/java/com/alibaba/nacos/client/config/listener/impl/ClientWorkerTest.java
Show resolved
Hide resolved
zongtanghu
changed the title
|
Please help to review this pr, thanks. @chuntaojun |
zongtanghu
reviewed
Jul 31, 2020
client/src/main/java/com/alibaba/nacos/client/config/impl/ClientWorker.java
Outdated
Show resolved
Hide resolved
KomachiSion
previously approved these changes
Jul 31, 2020
zongtanghu
reviewed
Jul 31, 2020
client/src/main/java/com/alibaba/nacos/client/config/impl/ClientWorker.java
Outdated
Show resolved
Hide resolved
|
@chuntaojun 春少可以一起来review下，这个PR，我的想法是，既然用了remove那么taskFlagMap 变成taskIdSets更为合适，也就是如上面留言所述的，HashMap -> HashSet. |
KomachiSion
approved these changes
Aug 5, 2020
|
LGTM |
zongtanghu
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Cancels the idle long polling thread.
#3368
Brief changelog
update ClientWorker.java
1:Add remakeCacheDataTaskId()
2:Add updateSchedulerMap()
3:Increase the processing if taskCount is reduced