Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix register null cluster name instance problem #3267

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ public interface HttpHeaderConsts {
String CONTENT_ENCODING = "Content-Encoding";
String CONNECTION = "Connection";
String REQUEST_ID = "RequestId";
String REQUEST_MODULE = "REQUEST_MODULE";
String REQUEST_MODULE = "Request-Module";

}
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,12 @@ public String toQueryUrl() {
int i = entrySet.size();
for (Map.Entry<String, Object> entry : entrySet) {
try {
urlBuilder.append(entry.getKey()).append("=")
.append(URLEncoder.encode(String.valueOf(entry.getValue()), "UTF-8"));
if (i > 1) {
urlBuilder.append("&");
if (null != entry.getValue()) {
urlBuilder.append(entry.getKey()).append("=")
.append(URLEncoder.encode(String.valueOf(entry.getValue()), "UTF-8"));
if (i > 1) {
urlBuilder.append("&");
}
}
i--;
} catch (UnsupportedEncodingException e) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public static void shutdownThreadPool(ExecutorService executor, Logger logger) {
while (retry > 0) {
retry--;
try {
if (executor.awaitTermination(10, TimeUnit.SECONDS)) {
if (executor.awaitTermination(1, TimeUnit.SECONDS)) {
return;
}
} catch (InterruptedException e) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/*
* Copyright 1999-2018 Alibaba Group Holding Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.alibaba.nacos.common.http.param;

import com.alibaba.nacos.api.naming.CommonParams;
import org.junit.Test;

import java.util.HashMap;
import java.util.Map;

import static org.junit.Assert.assertEquals;

public class QueryTest {

@Test
public void testToQueryUrl() {
Map<String, String> parameters = new HashMap<String, String>();
parameters.put(CommonParams.NAMESPACE_ID, "namespace");
parameters.put(CommonParams.SERVICE_NAME, "service");
parameters.put(CommonParams.GROUP_NAME, "group");
parameters.put(CommonParams.CLUSTER_NAME, null);
parameters.put("ip", "1.1.1.1");
parameters.put("port", String.valueOf(9999));
parameters.put("weight", String.valueOf(1.0));
parameters.put("ephemeral", String.valueOf(true));
String excepted = "groupName=group&namespaceId=namespace&port=9999&ip=1.1.1.1&weight=1.0&ephemeral=true&serviceName=service";
assertEquals(excepted, Query.newInstance().initParams(parameters).toQueryUrl());
}
}