Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3223] Upgrade log4j to security version #3229

Merged
merged 1 commit into from
Jul 3, 2020
Merged

[ISSUE #3223] Upgrade log4j to security version #3229

merged 1 commit into from
Jul 3, 2020

Conversation

J-Cod3r
Copy link
Contributor

@J-Cod3r J-Cod3r commented Jul 2, 2020

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Resolved #3223

Brief changelog

Upgrade log4j to security version

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@J-Cod3r
Copy link
Contributor Author

J-Cod3r commented Jul 2, 2020

CI failed reason:

org.apache.maven.surefire.booter.SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?

cause by my modification?

@KomachiSion
Copy link
Collaborator

CI failed reason:

org.apache.maven.surefire.booter.SurefireBooterForkException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?

cause by my modification?

I have restart CI. See it later

@KomachiSion KomachiSion added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 3, 2020
@KomachiSion KomachiSion added this to the 1.3.1 milestone Jul 3, 2020
@KomachiSion KomachiSion merged commit aa020e0 into alibaba:develop Jul 3, 2020
@J-Cod3r J-Cod3r deleted the upgrade-log4j-version branch July 3, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade log4j version to solve security alert
2 participants