Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX ISSUE #3007 : MaxHistory字段名称和Nacos默认的命名风格不统一 #3008

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

zhouhailin
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

"MaxHistory" naming rule is not nacos default style
MaxHistory字段名称和Nacos默认的命名风格不统一

Brief changelog

Verifying this change

address/src/main/resources/META-INF/logback/nacos-included.xml
config/src/main/resources/META-INF/logback/config-included.xml
core/src/main/resources/META-INF/logback/nacos.xml
distribution/conf/nacos-logback.xml
naming/src/main/resources/META-INF/logback/naming-included.xml

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2020

CLA assistant check
All committers have signed the CLA.

@KomachiSion KomachiSion linked an issue Jun 10, 2020 that may be closed by this pull request
@KomachiSion KomachiSion added this to the 1.3.1 milestone Jun 10, 2020
@KomachiSion
Copy link
Collaborator

@zhouhailin Thanks for your contribution, can you sign the cla so that I can merge your PR to main branch.

@zhouhailin
Copy link
Contributor Author

@zhouhailin Thanks for your contribution, can you sign the cla so that I can merge your PR to main branch.

singed cla already.

@KomachiSion KomachiSion merged commit e6c578f into alibaba:develop Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nacos Code Style - logback - "MaxHistory" Field
3 participants