Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2089]Config list return page bug fix #2737

Merged

Conversation

zhenxianyimeng
Copy link
Contributor

What is the purpose of the change

fix #2089

Brief changelog

store page info in url so keep page info when go back to list page

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@yanlinly yanlinly requested review from jameslcj and wfnuser and removed request for loadchange June 11, 2020 06:49
@CLAassistant
Copy link

CLAassistant commented Jun 12, 2020

CLA assistant check
All committers have signed the CLA.

@KomachiSion
Copy link
Collaborator

@zhenxianyimeng Sorry, can you recheck the cla? If you has signed CLA, please click recheck button. If not yet, Please sign it.

@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/Nacos console Related to Nacos consle labels Jun 15, 2020
@KomachiSion KomachiSion added this to the 1.3.1 milestone Jun 15, 2020
@zhenxianyimeng
Copy link
Contributor Author

@zhenxianyimeng Sorry, can you recheck the cla? If you has signed CLA, please click recheck button. If not yet, Please sign it.

ok i have done

@KomachiSion KomachiSion merged commit 49ff59e into alibaba:develop Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nacos config list page bug
4 participants