Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #12670: can't login when domain like 'register.nacos.com', ie. contains … #12671

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

juhuan
Copy link
Contributor

@juhuan juhuan commented Sep 19, 2024

…register. #12670

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

修复域名无法包含register的问题 #12670

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Sep 20, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.64%. Comparing base (3a9003b) to head (f233df2).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12671      +/-   ##
=============================================
- Coverage      69.70%   69.64%   -0.06%     
+ Complexity      9431     9414      -17     
=============================================
  Files           1275     1275              
  Lines          41232    41233       +1     
  Branches        4374     4374              
=============================================
- Hits           28740    28716      -24     
- Misses         10412    10437      +25     
  Partials        2080     2080              

see 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91987b0...f233df2. Read the comment docs.

@KomachiSion
Copy link
Collaborator

Hi, please sign your cla first.

your commit is not your github id and can't be relatived to your signed cla.

you should close this PR and create an new branch commit this change with your github id and email by git config

@juhuan
Copy link
Contributor Author

juhuan commented Sep 26, 2024

Hi, please sign your cla first.

your commit is not your github id and can't be relatived to your signed cla.

you should close this PR and create an new branch commit this change with your github id and email by git config

ok, done. pushed again.
CleanShot 2024-09-26 at 10 11 47@2x

@KomachiSion KomachiSion added area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug. labels Sep 27, 2024
@KomachiSion KomachiSion added this to the 2.5.0 milestone Sep 27, 2024
@KomachiSion KomachiSion merged commit 33ae058 into alibaba:develop Sep 27, 2024
7 checks passed
@KomachiSion KomachiSion modified the milestones: 2.5.0, 2.4.3 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants