-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor&Enhancement] Enhance naming server status check. #12573
[Refactor&Enhancement] Enhance naming server status check. #12573
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12573 +/- ##
==========================================
Coverage 69.63% 69.63%
- Complexity 9399 9408 +9
==========================================
Files 1275 1275
Lines 41161 41180 +19
Branches 4366 4370 +4
==========================================
+ Hits 28663 28677 +14
- Misses 10422 10425 +3
- Partials 2076 2078 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@KomachiSion 大佬这个死锁问题我想请教一下, 我看原因好像是Spring加载阶段多线程调用 |
有一些地方不是spring bean,不能直接在初始化的时候依赖。 |
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
Fixes #12526, check whether cp protocol has init before getting to avoid async get dead lock.
For #12504,#12541,#12558 Enhance naming server stauts check logic, which can downgrade the check to avoid affect core features.
But if no leader for raft group, the relative features still can't be used.
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.