Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12483] Configuration list adds configuration format #12491

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

tonycody
Copy link
Contributor

issue: #12483

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 64.51613% with 33 lines in your changes missing coverage. Please review.

Project coverage is 69.45%. Comparing base (c56c415) to head (f3b54e3).
Report is 3 commits behind head on develop.

Files Patch % Lines
...mpl/derby/ConfigInfoTagsRelationMapperByDerby.java 46.66% 5 Missing and 3 partials ⚠️
...datasource/impl/derby/ConfigInfoMapperByDerby.java 50.00% 4 Missing and 3 partials ⚠️
...datasource/impl/mysql/ConfigInfoMapperByMySql.java 53.33% 5 Missing and 2 partials ⚠️
...cos/plugin/datasource/mapper/ConfigInfoMapper.java 36.36% 4 Missing and 3 partials ⚠️
...cos/config/server/controller/ConfigController.java 33.33% 2 Missing ⚠️
...ce/impl/mysql/ConfigTagsRelationMapperByMySql.java 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12491      +/-   ##
=============================================
+ Coverage      69.38%   69.45%   +0.06%     
- Complexity      9427     9452      +25     
=============================================
  Files           1281     1282       +1     
  Lines          41488    41558      +70     
  Branches        4388     4397       +9     
=============================================
+ Hits           28788    28863      +75     
+ Misses         10632    10618      -14     
- Partials        2068     2077       +9     
Files Coverage Δ
...embedded/EmbeddedConfigInfoPersistServiceImpl.java 81.89% <100.00%> (ø)
.../extrnal/ExternalConfigInfoPersistServiceImpl.java 76.19% <100.00%> (ø)
...in/datasource/mapper/ConfigTagsRelationMapper.java 80.95% <100.00%> (ø)
...cos/config/server/controller/ConfigController.java 69.19% <33.33%> (ø)
...ce/impl/mysql/ConfigTagsRelationMapperByMySql.java 87.50% <87.50%> (ø)
...datasource/impl/derby/ConfigInfoMapperByDerby.java 69.34% <50.00%> (ø)
...datasource/impl/mysql/ConfigInfoMapperByMySql.java 68.93% <53.33%> (ø)
...cos/plugin/datasource/mapper/ConfigInfoMapper.java 72.09% <36.36%> (ø)
...mpl/derby/ConfigInfoTagsRelationMapperByDerby.java 63.63% <46.66%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c56c415...f3b54e3. Read the comment docs.

@@ -0,0 +1,31 @@
/*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what it means? Please explain.

@KomachiSion KomachiSion added this to the 2.4.2 milestone Aug 19, 2024
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. area/Nacos console Related to Nacos consle labels Aug 19, 2024
@KomachiSion KomachiSion merged commit c2e5ee6 into alibaba:develop Aug 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants