-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE#12359]Refactoring the historical configuration cleanup strategy with SPI #12367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这种方案是否要求拓展者必须依赖nacos-config模块才可以开发拓展?
是的 |
.../test/java/com/alibaba/nacos/config/server/service/dump/DefaultHistoryConfigCleanerTest.java
Outdated
Show resolved
Hide resolved
config/src/main/java/com/alibaba/nacos/config/server/service/dump/HistoryConfigCleaner.java
Outdated
Show resolved
Hide resolved
@Override | ||
public void run() { | ||
clearConfigHistory(); | ||
LOGGER.warn("clearHistoryConfig start"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.when canExecute return false/true ,print log also ,like 'history config cleaner is not enable in current context' , 'history config cleaner is enable in current context, trying to run cleaner.'
2.when cleaner run finish ,print log like 'history cleaner finished successfully' and should catch exception when cleaner throw exception ,or it wont be scheduled next period.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
fix issue#12359
Brief changelog
Refactoring the historical configuration cleanup strategy with SPI (Service Provider Interface), and add unit test for
DefaultHistoryConfigCleaner ,HistoryConfigCleanerManager and HistoryConfigCleanerConfig
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.