-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #12342]: Improve the retrieval of ConfigInfoState to facilitate the extension and implementation of databases like Oracle. #12343
base: develop
Are you sure you want to change the base?
Conversation
…and implementation of databases like Oracle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah
Can you add unit test for this? |
…foPersistServiceImpl#findConfigInfoState` method.
The SQL construction logic of the |
I see the CLA has no signed. Can you sign the CLA? |
CLA has been signed. |
… using a unified appendWhereClause method to construct the WHERE clause. Modify appendWhereClause to be protected, allowing for customization based on different database types, such as adjustments according to column names.
@KomachiSion Could this change be merged? Thank you. |
What is the purpose of the change
fixes #12342
Improve the retrieval of ConfigInfoState to facilitate the extension and implementation of databases like Oracle.
Brief changelog
Generate the SQL required by
ExternalConfigInfoPersistServiceImpl#findConfigInfoState
using theselect
method fromMapperManager
.Verifying this change
We have already used this method in the production environment, adapting the configuration management for both Oracle and MySQL databases.