Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12301] 相同永久实例在不同nameSpace下面健康检测问题 #12310

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

chen10038
Copy link
Contributor

@chen10038 chen10038 commented Jul 4, 2024

Please do not create a Pull Request without creating an issue first.

for #12301

What is the purpose of the change

fix #12301
Beat 对象toString()增加 nameSpace区分
tryStartCheck日志打印增加nameSpace区分

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Jul 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign your CLA first, and help community add unit test for your changes.

@chen10038 chen10038 closed this Jul 8, 2024
@chen10038 chen10038 reopened this Jul 8, 2024
@chen10038 chen10038 closed this Jul 8, 2024
@chen10038 chen10038 deleted the my_dev_branch branch July 8, 2024 06:33
@chen10038 chen10038 reopened this Jul 8, 2024
@chen10038
Copy link
Contributor Author

修改了本地git配置完成CLA。重新修改toString方法,否则超过限制的150的length。麻烦再review一下。

@KomachiSion
Copy link
Collaborator

Can you add unit test for this?

@KomachiSion KomachiSion merged commit 525f3bf into alibaba:develop Jul 31, 2024
13 checks passed
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/Naming labels Jul 31, 2024
@KomachiSion KomachiSion added this to the 2.4.1 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Naming kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

相同永久实例在不同nameSpace下面健康检测问题
3 participants